Change generic form selector from class into id #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some examples on this page are using `$(".selector").validate()` and others are using `$("#myform").validate()`.
Using `$(".selector")` implies that `.validate()` can be directly attached to a class selector where, if this is done without using an `.each()`, it would only be attached to the first instance of this class.
The `$(".selector")` should be changed into `$("#myform")` on the entire page for better consistency and less confusion. I think `$("#myform")` is more appropriate since the `.validate()` method should only be attached to a selector that represents a single `form` element.
|
thanks. |
|
merged via 49ce0cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples on this page are using
$(".selector").validate()and others are using$("#myform").validate().Using
$(".selector")implies that.validate()can be directly attached to a class selector where, if this is actually done without wrapping it within an.each(), it would only be attached to the first instance of this class.The
$(".selector")should be changed into$("#myform")on the entire page for consistency with the other examples and less confusion. I think$("#myform")is more appropriate since the.validate()method should only be attached to a selector that represents a singleformelement.