Update reference.md #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified this section to reflect many questions on StackOverflow. It's a common mistake to leave out or duplicate the `name` attribute. It's also a common misconception that an `id` is needed at all for this plugin to work. Nowhere in the documentation is it explicitly stated that `name` attribute must be unique... only implied. My proposed changes spells these items out more clearly. The most important markup requirements are moved to the very top of this section in a paragraph preceded by the word "Mandated". Removed the triple single quotes from the word "required" as this just seems like we're talking about the `required` rule. And to eliminate any confusion, anything that has no effect on the operation of the plugin is confined to a paragraph preceded by the word "Optionally".
| @@ -10,14 +10,15 @@ To achieve this, it is important that the plugin is actually deployed on website | |||
| The plugin can never replace serverside validation and doesn't intend to do so. Having both in place gives you the necessary security for your application, as well as improved usability. | |||
|
|
|||
| # Markup recommendations | |||
| Each input has a label associated with it: The for-attribute of the label refers to the id-attribute of the input. | |||
| Mandated: A 'name' attribute is required for all input elements needing validation, and the plugin will not work without this. A 'name' attribute must also be unique to the form, as this is how the plugin keeps track of all input elements. | |||
There was a problem hiding this comment.
Checkbox/radios can have equal names
There was a problem hiding this comment.
Checkbox/radios can have equal names
This is true. However, a group of these elements are treated like a single data input point. Give two different groups of radio or checkbox elements the same name and you'll have an issue where they're all lumped together incorrectly:
I'll make some clarifications to note this exception.
|
manually merged, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified this section to reflect many questions on StackOverflow. It seems to be a common mistake to leave out or duplicate the
nameattribute. It's also a misconception that anidis needed at all for this plugin to work. Nowhere in the documentation is it explicitly stated thatnameattribute must be unique... only implied. My proposed changes spells these items out more clearly.The most important markup requirements are moved to the very top of this section in a paragraph preceded by the word "Mandated". Removed the triple single quotes from the word "required" as this just seems like we're talking about the
requiredrule.And to eliminate any confusion, anything that has no effect on the operation of the plugin is confined to a paragraph preceded by the word "Optionally".