Skip to content

Entries: document the ability to define a global normalizer #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2017

Conversation

Arkni
Copy link
Member

@Arkni Arkni commented Feb 12, 2017

Please don't merge, the global normalizer is not released yet.

refs jquery-validation/jquery-validation@a88ae88

Copy link
Member Author

@Arkni Arkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self

normalizer: function( value ) {
return $.trim( value );
},
rules: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should use either spaces or tabs

@Arkni
Copy link
Member Author

Arkni commented Apr 11, 2017

I should also add the normalizer to validate() docs
Done!

@Arkni Arkni force-pushed the global-normalizer branch from 4bb3238 to 10d33a5 Compare June 17, 2017 15:19
</example>

<example>
<desc>Using a global normalizer in conjunction with a local one</desc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we note the version in which this new api was added? (Not sure we do it in other places)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we never added the version to any of the available API, nor it was added before.
If you want I can add it, but that will be inconsistent with the rest of the documentation.

@staabm staabm merged commit c550458 into jquery-validation:master Jun 25, 2017
@staabm
Copy link
Member

staabm commented Jun 25, 2017

Ok, merge as is. Thx @Arkni

@Arkni Arkni deleted the global-normalizer branch June 25, 2017 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants