Entries: Note that the normalizer can return any value #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Sep 3, 2017
entries/normalizer.xml
Outdated
| @@ -13,7 +13,7 @@ | |||
| <ul> | |||
| <li><p>Doesn't change the elements' value, it only changes the value used for validation.</p></li> | |||
| <li><p>Gets the value passed as argument, and "this" within it references the corresponding <code>DOMElement</code>.</p></li> | |||
| <li><p>Needs to return a String value, otherwise it will throw a <code>TypeError</code> exception.</p></li> | |||
| <li><p>Can return any value including <code>null</code> and <code>undefined</code>.</p></li> | |||
There was a problem hiding this comment.
We should note the version since when this is supported
There was a problem hiding this comment.
In that case, I will wait for the next release to update it.
There was a problem hiding this comment.
Next will be a minor non-feature release
fdc27fb to
0056c99
Compare
0056c99 to
a81c46b
Compare
|
Hi @staabm, I totally forgot about this PR. Could you please merge it and if it's not too much, can you also deploy this change? Thanks a lot :) |
|
ohh missed it :-). merged it, will deploy when time allows. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jquery-validation/jquery-validation#2054