Skip to content

keypress event mistakenly says "keyup" #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjorford opened this issue Jan 28, 2025 · 1 comment · Fixed by #1272
Closed

keypress event mistakenly says "keyup" #1266

sjorford opened this issue Jan 28, 2025 · 1 comment · Fixed by #1272

Comments

@sjorford
Copy link

https://api.jquery.com/keypress/

The event signatures both say "keyup" instead of "keypress":

.on( "keyup" [, eventData ], handler )

.trigger( "keyup" )

Seems to have been introduced in the last revision when .keypress() and similar methods were deprecated
@mgol
Copy link
Member

mgol commented Jan 29, 2025

Thanks for the report. Would you like to submit a PR with a fix?

@aldimar-junior aldimar-junior mentioned this issue Apr 7, 2025
Merged
@mgol mgol closed this as completed in #1272 Apr 8, 2025
mgol pushed a commit that referenced this issue Apr 8, 2025
@aldimar-junior
keypress: Fix typos: keyup -> keypress
22f2e65 
Fixes gh-1266
Closes gh-1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing keypress docs renaming wrong instances of "keyup" aldimar-junior/api.jquery.com
2 participants
@mgol @sjorford