Skip to content

fx.interval still mentions requestAnimationFrame #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kitchin opened this issue Nov 3, 2013 · 4 comments
Closed

fx.interval still mentions requestAnimationFrame #380

kitchin opened this issue Nov 3, 2013 · 4 comments

Comments

@kitchin
Copy link

kitchin commented Nov 3, 2013

requestAnimationFrame is no longer in jQuery. But it's still mentioned here: http://api.jquery.com/jQuery.fx.interval/ (just before the example).

@kitchin
Copy link
Author

kitchin commented Nov 3, 2013

See also the doc bug that added the line I propose removing or modding: http://bugs.jquery.com/ticket/9497

Looks like requestAnimationFrame was in added in 1.6 and removed in 1.6.3.

A flag "supports.raf" was proposed but it never happened and I can't find any bugs on putting requestAnimationFrame back into core. There is a plugin instead http://plugins.jquery.com/requestAnimationFrame/

The problem is called "creating wormholes", see http://blog.jquery.com/2011/09/01/jquery-1-6-3-released/

@fALKENdk
Copy link

fALKENdk commented Nov 3, 2013

I think its a refercance to this : it https://developer.mozilla.org/en-US/docs/Web/API/window.requestAnimationFrame

@kitchin
Copy link
Author

kitchin commented Nov 4, 2013

But jQuery does not use it. The text

"jQuery.fx.interval currently has no effect in browsers that support the requestAnimationFrame property, such as Google Chrome 11. This behavior is subject to change in a future release."

should be

"In version 1.6, jQuery implemented requestAnimationFrame in browsers that supported it. This meant fx.interval had no effect in Chrome 11, for example. In version 1.6.3, jQuery removed requestAnimationFrame, so fx.interval again became effective in all browsers. (A jQuery plugin is available to implement requestAnimationFrame in version 1.8: https://github.com/gnarf/jquery-requestAnimationFrame )."

@kswedberg
Copy link
Member

Thanks @kitchin. The fix will appear on the live site the next time the repo is tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants