jQuery.ajax: success callback and dataFilter signatures should use Anything type
#492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Anything left to do on this? @rwaldron @scottgonzalez @dmethvin |
Member
|
LGTM |
usmonster
added a commit
to usmonster/closure-compiler
that referenced
this pull request
Nov 4, 2014
- Loosens type of jQuery.each callback's first parameter; common subtype ? preferred to (string|number). - Deprecates jQuery.support (see jquery/api.jquery.com#454). - Adds other possible return values to jQuery.parseJSON (see jquery/api.jquery.com#492). - Loosens return type of `dataFilter` function passed to $.ajax (see jquery/api.jquery.com#492). - Updates `@see` reference to link to proper issue in old tracker. Resolves google#694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This was discussed on another issue and recommended to be reported separately.)
The signature for the
successcallback ofjQuery.ajaxis misleading in that it denotes that the function will be passed aPlainObjectas its first argument, even though it is later (and more accurately) noted that the passed argument is "formatted according to thedataTypeparameter." Indeed, thedatacan even potentially be of any type if one uses customconverters. The same issue exists for thedataFiltersetting's function signature.These signatures should probably use
Anythingin place of[Plain]Object.