Skip to content

Documents "Anything" virtual type #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

usmonster
Copy link
Contributor

Implements part of gh-391.

Let me know if there's anything off in the wording.

@usmonster
Copy link
Contributor Author

ping @scottgonzalez

@usmonster
Copy link
Contributor Author

Also related: gh-492

@scottgonzalez
Copy link
Member

This looks good to me. @dmethvin @kswedberg @tjvantoll Anyone else want to review?

@tjvantoll
Copy link
Member

This is trivial, but you could remove "at all" because it's redundant. This looks good.

@dmethvin
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants