Skip to content

Document that .toggleClass( boolean ) has been deprecated in jQuery 3 #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AurelioDeRosa opened this issue Dec 16, 2015 · 4 comments
Closed

Document that .toggleClass( boolean ) has been deprecated in jQuery 3 #851

AurelioDeRosa opened this issue Dec 16, 2015 · 4 comments
Milestone
3.0.0

Comments

@AurelioDeRosa
Copy link
Member

Reference: jquery/jquery#2618.
@AurelioDeRosa AurelioDeRosa added this to the 3.0.0 milestone Dec 16, 2015
@dmethvin
Copy link
Member

Given that is wasn't really documented before (just a signature with no real explanation) I wonder if we should relegate this to the release notes.

@timmywil timmywil modified the milestone: 3.0.0 Jan 7, 2016
@timmywil
Copy link
Member

timmywil commented Jan 7, 2016

We've decided to save this removal for 4.0. We just need to mark it deprecated in 3.0.

@timmywil timmywil changed the title Document that .toggleClass( boolean ) has been removed in jQuery 3 Document that .toggleClass( boolean ) has been deprecated in jQuery 3 Jan 7, 2016
AurelioDeRosa added a commit to AurelioDeRosa/api.jquery.com that referenced this issue Jan 8, 2016
@AurelioDeRosa
toggleClass: Document deprecation of a signature
e6ff90e 
Fixes jquerygh-851
@AurelioDeRosa AurelioDeRosa mentioned this issue Jan 8, 2016
Closed
@dmethvin
Copy link
Member

Oh I missed that I guess. Yes, it's still in master so deprecate in 3.0 and remove in 4.0 then.

@AurelioDeRosa
Copy link
Member Author

No worries Dave.

AurelioDeRosa added a commit that referenced this issue Jan 16, 2016
@AurelioDeRosa
toggleClass: Document deprecation of a signature
0e81757 
Fixes gh-851
Closes gh-860
@mgol mgol mentioned this issue Feb 10, 2016
Closed
AurelioDeRosa added a commit that referenced this issue May 23, 2016
@AurelioDeRosa
toggleClass: Document deprecation of a signature
d8cc2db 
Fixes gh-851
Closes gh-860
timmywil pushed a commit that referenced this issue Jun 9, 2016
@AurelioDeRosa @timmywil
toggleClass: Document deprecation of a signature
d6d3e7a 
Fixes gh-851
Closes gh-860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@dmethvin @timmywil @AurelioDeRosa