Skip to content

.data() api #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feiwen8772 opened this issue Jul 1, 2016 · 5 comments
Closed

.data() api #943

feiwen8772 opened this issue Jul 1, 2016 · 5 comments

Comments

@feiwen8772
Copy link
Contributor

http://api.jquery.com/data/
the algorithm of the Dataset API
not transforms URL

@feiwen8772
Copy link
Contributor Author

467d3ef5-cc98-46d6-a396-d998c0adbfce

@mgol
Copy link
Member

mgol commented Jul 6, 2016

@AurelioDeRosa You need to run npm version patch and push the tag to the repo to trigger the page update, otherwise nothing happens.

EDIT: I've just done it.

@AurelioDeRosa
Copy link
Member

Hey @mgol.

I knew it but usually I try to push a couple of changes before creating a new version.

@mgol
Copy link
Member

mgol commented Jul 10, 2016

Why? I don't see why it's necessary to wait for a week or two before a merged change gets published; I think we should do it immediately - the code is there, people should be able to see the updated site.

@AurelioDeRosa
Copy link
Member

Well, I didn't write "wait for 1-2 weeks". I wrote "1-2 changes", which means merge 1-2 changes within 1-2 days and then push. If I forgot to push the change in one occasion, that's a different story.

Arkni added a commit to Arkni/api.jquery.com that referenced this issue Mar 18, 2018
mgol pushed a commit that referenced this issue Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants