Skip to content

outerHeight(): Specified type of passed arguments to callback#1009

Merged
mgol merged 3 commits into
jquery:masterfrom
AurelioDeRosa:outerHeight
Mar 22, 2017
Merged

outerHeight(): Specified type of passed arguments to callback#1009
mgol merged 3 commits into
jquery:masterfrom
AurelioDeRosa:outerHeight

Conversation

@AurelioDeRosa
Copy link
Copy Markdown
Member

Fixes gh-989

@AurelioDeRosa AurelioDeRosa requested a review from agcolom January 3, 2017 10:29
@mgol
Copy link
Copy Markdown
Member

mgol commented Jan 24, 2017

This looks good but the same changes should be applied to outerWidth. The inner* variants already look fine.

@AurelioDeRosa
Copy link
Copy Markdown
Member Author

@mgol I've updated the PR.

Comment thread entries/outerWidth.xml Outdated
<argument name="function(index, width)" type="Function">
<argument name="function" type="Function">
<argument name="index" type="Integer" />
<argument name="height" type="Number" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width, not height :)

@mgol mgol merged commit 90321ab into jquery:master Mar 22, 2017
@AurelioDeRosa AurelioDeRosa deleted the outerHeight branch April 25, 2017 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants