Skip to content

load(): Specified that load event alias is deprecated #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

load(): Specified that load event alias is deprecated #1010

wants to merge 1 commit into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes #976

@AurelioDeRosa AurelioDeRosa requested a review from mgol December 20, 2016 21:38
@AurelioDeRosa AurelioDeRosa requested a review from agcolom January 3, 2017 10:28
@mgol
Copy link
Member

mgol commented Jan 24, 2017

The code changes look good but the commit message is incorrect - the alias is now no longer just deprecated but removed.

@AurelioDeRosa
Copy link
Member Author

Thank you for the review. I'm going to change the commit message when rebasing.

@AurelioDeRosa AurelioDeRosa deleted the load branch January 24, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol Awaiting requested review from mgol

@agcolom agcolom Awaiting requested review from agcolom

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelioDeRosa @mgol