Improve jqXHR documentation#1020
Closed
gibson042 wants to merge 5 commits into
Closed
Conversation
dmethvin
reviewed
Jan 23, 2017
| <code>getAllResponseHeaders()</code> | ||
| <code>abort( [ statusText ] )</code> | ||
| </li> | ||
| <li> |
Member
There was a problem hiding this comment.
Is it worth adding "as a string" here? The others don't talk about return types in general.
Member
Author
There was a problem hiding this comment.
Absent prior knowledge, I'd expect getAllResponseHeaders() to return a map. This clarifies that to not be the case.
dmethvin
approved these changes
Jan 24, 2017
Member
|
Should I keep all the commits here or should I fix up them? |
Member
Author
|
They'll always be distinct here; I'm not opposed to a landing them on master as a single unit. |
Member
|
Yeah, my question was basically if there was any preference on how to merge them in master. |
Member
Author
|
I personally prefer the squashed representation, and that's also our standard in Core and QUnit. |
Member
|
Is anything blocking landing this? |
Member
|
@mgol Not that I'm aware of. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-1019