Skip to content

contextmenu: Menu button trigger not just on root #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Herst
Copy link
Contributor

@Herst Herst commented Nov 6, 2017

See also https://developer.mozilla.org/en-US/docs/Web/Events/contextmenu.

On a side note, can the root element always be assumed to be html?

@jsf-clabot
Copy link

jsf-clabot commented Nov 6, 2017

CLA assistant check
All committers have signed the CLA.

@AurelioDeRosa
Copy link
Member

Thank you for contributing. In an HTML document, the root will always be the html element.

@mgol
Copy link
Member

mgol commented Feb 10, 2018

@AurelioDeRosa The PR's intention wasn't to specify if the html element is equivalent to the root element but to specify the keyboard-activated context menu fires the contextmenu event at the currently focused element. I'll reopen it then.

@Herst Have you verified that this behavior is true? I don't have a Windows laptop to check that and Macs don't have the context menu key.

@mgol mgol reopened this Feb 10, 2018
@AurelioDeRosa
Copy link
Member

AurelioDeRosa commented Feb 11, 2018

@mgol I know the PR wasn't about that, I replied to the question asked in this very PR.

On a side note, can the root element always be assumed to be html?

Also, I'm a Windows user and I did verify that this is true. That's why I merged the PR.

@mgol
Copy link
Member

mgol commented Feb 11, 2018

Sorry, my bad. Somehow I thought you rejected it, not landed. Closing again then!

@mgol mgol closed this Feb 11, 2018
@Herst
Copy link
Contributor Author

Herst commented Feb 11, 2018

@mgol Yes, I have confirmed the behavior and not just on Windows BTW.

Cocerning the root document question I asked because when reading the documentation here I remembered that are reset stylesheets which for some reason use :root instead of the html selector in some places.

Again on a side note, I am using the contextmenu event to reliably prevent long-press touches from causing the context menu to pop up on certain interactive elements. Sadly there seems to be no way to prevent specifically prevent the event calls which where the result of a long-tap action as opposed to a right-click, see: https://stackoverflow.com/q/47202631/2261442 I would be glad if someone here knows the right committees or such where such feature requests could be brought up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants