Added note about the deprecation of jQuery.isFunction in version 3.3#1077
Closed
AurelioDeRosa wants to merge 1 commit into
Closed
Added note about the deprecation of jQuery.isFunction in version 3.3#1077AurelioDeRosa wants to merge 1 commit into
AurelioDeRosa wants to merge 1 commit into
Conversation
dmethvin
approved these changes
Feb 9, 2018
mgol
requested changes
Feb 9, 2018
| <desc>Determine if the argument passed is a JavaScript function object. </desc> | ||
| <desc>Determine if the argument passed is a JavaScript function object.</desc> | ||
| <longdesc> | ||
| <p>As of jQuery 3.3, <code>jQuery.isFunction()</code> has been deprecated. In most cases, its use can be replaced by <code>typeof obj === "function"</code>.</p> |
Member
There was a problem hiding this comment.
I'd change typeof obj === "function" to typeof x === "function"; obj suggests object is an input and that's not required.
Member
Author
There was a problem hiding this comment.
Good suggestion. Updating now.
8d2892f to
fd29dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-1074