Skip to content

Fix the build #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2018
Merged

Fix the build #1080

merged 3 commits into from
Feb 8, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Feb 7, 2018

Commit summary:

  • Build: Update Node from 0.12 to 8
  • Build: Don't install grunt-cli manually in Travis
  • Build: Install the libxml2-utils package on Travis, it's needed for xmllint

mgol added 2 commits February 7, 2018 09:29
@mgol
Build: Update Node from 0.12 to 8
82322be
@mgol
Build: Don't install grunt-cli manually in Travis
c5ad660 
It's not needed as npm scripts have node_modules/.bin prepended to PATH.
It's also better to have all versions as locked up as possible to prevent build
instability.
@mgol mgol requested a review from dmethvin February 7, 2018 10:05
dmethvin
dmethvin approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, it's been a while on that!

@mgol mgol merged commit 077f1be into jquery:master Feb 8, 2018
@mgol mgol deleted the build-updates branch February 8, 2018 21:17
@mgol
Copy link
Member Author

mgol commented Feb 8, 2018 •
edited
Loading

We finally have a green build. 😄

@AurelioDeRosa
Copy link
Member

Thank you for doing this @mgol!

@AurelioDeRosa AurelioDeRosa mentioned this pull request Feb 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmethvin dmethvin dmethvin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgol @AurelioDeRosa @dmethvin