Skip to content

Misc: Change HTTP links to HTTPS where possible #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Misc: Change HTTP links to HTTPS where possible #1089

merged 1 commit into from
Mar 30, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 26, 2018

@mgol mgol requested a review from AurelioDeRosa March 26, 2018 17:10
@mgol
Copy link
Member Author

mgol commented Mar 28, 2018

If no one opposes I'd like to land it soon.

dmethvin
dmethvin approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once that typo is fixed this looks good to land!

CONTRIBUTING.md Outdated

You may also want to take a look at our [commit & pull request guide](http://contribute.jquery.org/commits-and-pull-requests/) and [style guides](http://contribute.jquery.org/style-guide/) for instructions on how to maintain your fork and submit your code. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](http://contribute.jquery.org/cla).
You may also want to take a look at our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](httsp://contribute.jquery.org/style-guide/) for instructions on how to maintain your fork and submit your code. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: httsp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye!

@mgol mgol merged commit 8e67f74 into jquery:master Mar 30, 2018
@mgol mgol deleted the httpsify branch March 30, 2018 14:41
@mgol
Copy link
Member Author

mgol commented Mar 30, 2018

Thanks, Dave. Typo corrected & landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmethvin dmethvin dmethvin approved these changes

@AurelioDeRosa AurelioDeRosa Awaiting requested review from AurelioDeRosa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @dmethvin