Skip to content

Misc: Change HTTP links to HTTPS where possible#1089

Merged
mgol merged 1 commit into
jquery:masterfrom
mgol:httpsify
Mar 30, 2018
Merged

Misc: Change HTTP links to HTTPS where possible#1089
mgol merged 1 commit into
jquery:masterfrom
mgol:httpsify

Conversation

@mgol
Copy link
Copy Markdown
Member

@mgol mgol commented Mar 26, 2018

@mgol mgol requested a review from AurelioDeRosa March 26, 2018 17:10
@mgol
Copy link
Copy Markdown
Member Author

mgol commented Mar 28, 2018

If no one opposes I'd like to land it soon.

Copy link
Copy Markdown
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once that typo is fixed this looks good to land!

Comment thread CONTRIBUTING.md Outdated
Welcome! Thanks for your interest in contributing to api.jquery.com. You're **almost** in the right place. More information on how to contribute to this and all other jQuery Foundation projects is over at [contribute.jquery.org](https://contribute.jquery.org). You'll definitely want to take a look at the articles on contributing [documentation](https://contribute.jquery.org/documentation).

You may also want to take a look at our [commit & pull request guide](http://contribute.jquery.org/commits-and-pull-requests/) and [style guides](http://contribute.jquery.org/style-guide/) for instructions on how to maintain your fork and submit your code. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](http://contribute.jquery.org/cla).
You may also want to take a look at our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](httsp://contribute.jquery.org/style-guide/) for instructions on how to maintain your fork and submit your code. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: httsp

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye!

@mgol mgol merged commit 8e67f74 into jquery:master Mar 30, 2018
@mgol mgol deleted the httpsify branch March 30, 2018 14:41
@mgol
Copy link
Copy Markdown
Member Author

mgol commented Mar 30, 2018

Thanks, Dave. Typo corrected & landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants