Skip to content

data: Explicitly disavow writing data-* attributes #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2018
Merged

data: Explicitly disavow writing data-* attributes #1112

merged 4 commits into from
Nov 21, 2018

Conversation

gibson042
Copy link
Member

Also includes general cleanup.

Fixes gh-1023

@gibson042 gibson042 mentioned this pull request Oct 22, 2018
Closed
mgol
mgol reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments but overall looks clearer to me than the previous version.

@mgol
Copy link
Member

mgol commented Oct 23, 2018

@coldice could you have a look? The clarification related to #1023 is the second commit of the PR: 34b6d52

@coldice
Copy link

coldice commented Oct 23, 2018

@mgol Looks good 👍 The change in line 80 to "[..] allows us to read data [..]" also clarifies it very well. Thank you.

@mgol mgol merged commit 3d88fc6 into jquery:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @mgol @coldice