Skip to content

Document optional includeMargin argument #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Document optional includeMargin argument #1133

wants to merge 1 commit into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes gh-1107

mgol
mgol approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the best API (a boolean trap) but we're documenting a de-facto state here so LGTM. Thanks!

@AurelioDeRosa
Copy link
Member Author

@mgol agree on the Boolean trap it was implemented. As you mentioned, we're just documenting what has been there since a few years now.

@AurelioDeRosa AurelioDeRosa deleted the outer branch May 7, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flag 'includeMargin' not documented but actually exists for setters outerWidth(value) and outerHeight(value)
2 participants
@AurelioDeRosa @mgol