All: Mark positional selectors as deprecated since jQuery 3.4.0#1145
Merged
Conversation
88c014c to
db75102
Compare
Positional selectors: :first, :last, :eq, :even, :odd, :lt, :gt, and :nth are deprecated since jQuery 3.4.0. This is now reflected in the docs & deprecated pseudo-classes are not used in examples on other API pages. Fixes jquerygh-1144
dmethvin
approved these changes
Sep 2, 2019
Member
dmethvin
left a comment
There was a problem hiding this comment.
Looks like you caught all the usage, thanks! I don't know how common the even/odd usage is. We should put it into Migrate for sure. If we don't put it in core we could just mention the simple implementation of each in the Migrate warning and people can add that to their code.
Member
Author
|
This is the implementation that adds +25 bytes: mgol/jquery@f454097 even: function() {
return this.filter( function( i ) {
return ( i + 1 ) % 2;
} );
},
odd: function() {
return this.filter( function( i ) {
return i % 2;
} );
}, |
Member
Author
|
OK, I'm going to merge it; we can discuss the |
Member
Author
|
I extracted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positional selectors:
:first,:last,:eq,:even,:odd,:lt,:gt, and:nthare deprecated since jQuery 3.4.0. This is now reflected in the docs & most deprecated pseudo-classes are not used in examples on other API pages.The only exception is
:even&:oddwhich are still used on some pages. I wasn't sure whether I should migrate them to a custom implementation using.filter()or whether we want.even()&.odd()in Core. I did a quick implementation to check the size impact & that would add 25 bytes to the gzipped file.Fixes gh-1144