All: Updates for jQuery 1.12/2.2-3.5#1160
Merged
Merged
Conversation
dmethvin
approved these changes
Apr 23, 2020
Member
dmethvin
left a comment
There was a problem hiding this comment.
Wow, awesome! 👏 This cleans up a lot of docs debt!
Member
Author
|
@dmethvin Thanks for feedback! I addressed all your comments. |
Member
|
This is fantastic, @mgol . Thank you!! |
timmywil
reviewed
Apr 28, 2020
| </signature> | ||
| <signature> | ||
| <added>1.12/2.2</added> | ||
| <added>1.12-2.2</added> |
Member
There was a problem hiding this comment.
Is the dash necessary? This implies that all the versions between 1.12 and 2.2 are involved.
Member
There was a problem hiding this comment.
I understand the / doesn't work, but what about a +, space, &, or |?
Member
Author
There was a problem hiding this comment.
Neither of these work, unfortunately. :( Neither does _ or ,. The checks there are pretty restrictive...
I went for 1.12-and-2.2. Not pretty but perhaps clearer that what we have now.
timmywil
approved these changes
Apr 28, 2020
Member
timmywil
left a comment
There was a problem hiding this comment.
Just one comment. Otherwise, LGTM.
Fixes jquery#947 Fixes jquery#949 Fixes jquery#950 Fixes jquery#1142 Ref jquery#970 Ref jquery#972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has many changes but the ones on which I'd focus the most during reviews are:
even/odddocs, removal of:even/:oddusage on API pagesaddClass/removeClass/toggleClass: array input signature + exampleshtmlPrefilter: rewritten, examples removed. The previous example of a more thorough check still wasn't covering all the cases so I didn't want people to have an impression this can be done securely like that.Fixes #947
Fixes #949
Fixes #950
Fixes #1142
Ref #970
Ref #972