Skip to content

jQuery.extend: Separate the one-argument signature from the multiple-arguments one #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 22, 2020

This is done to reduce the confusion as the single-argument signature behaves
completely differently than the other one.

Ref jquery/jquery#4748
Fixes gh-1164

…arguments one

This is done to reduce the confusion as the single-argument signature behaves
completely differently than the other one.

Ref jquery/jquery#4748
Fixes jquerygh-1164
@mgol mgol requested a review from a team July 22, 2020 11:56
@mgol
Copy link
Member Author

mgol commented Jul 22, 2020

Before:
Screen Shot 2020-07-22 at 13 57 20

After:
Screen Shot 2020-07-22 at 13 57 32

@mgol
Copy link
Member Author

mgol commented Jul 22, 2020

Is the order fine or would it be better to have the separated single-arg signature immediately follow the first one?

@kswedberg
Copy link
Member

@mgol fwiw, I like the way you have it, because the first 2 now seem more closely related conceptually.

@mgol
Copy link
Member Author

mgol commented Jul 27, 2020

@mgol fwiw, I like the way you have it, because the first 2 now seem more closely related conceptually.

Yeah, that was my thinking as well. I'm glad you like it. :)

@mgol mgol merged commit f40063e into jquery:master Jul 27, 2020
@mgol mgol deleted the jquery-extend branch July 27, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

jQuery.extend: separate one arg sig from 2+ args sig
3 participants