Skip to content

jQuery.trim: Describe differences between String#trim & jQuery.trim#1175

Merged
mgol merged 3 commits into
jquery:masterfrom
ssg:master
Aug 24, 2020
Merged

jQuery.trim: Describe differences between String#trim & jQuery.trim#1175
mgol merged 3 commits into
jquery:masterfrom
ssg:master

Conversation

@ssg
Copy link
Copy Markdown
Contributor

@ssg ssg commented Aug 20, 2020

This fixes #1174

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Aug 20, 2020

CLA assistant check
All committers have signed the CLA.

@timmywil
Copy link
Copy Markdown
Member

I like it.

Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a few suggestions

Comment thread entries/jQuery.trim.xml Outdated
Comment thread entries/jQuery.trim.xml Outdated
Comment thread entries/jQuery.trim.xml Outdated
Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mgol mgol changed the title update deprecation note for jQuery.trim() jQuery.trim: Describe differences between String#trim & jQuery.trim Aug 24, 2020
@mgol mgol merged commit 5120543 into jquery:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

String.prototype.trim() isn't 100% compatible with jQuery.trim()

4 participants