removeClass: Separate the signature with no parameters#1187
Merged
Conversation
That signature removes all classes which wasn't that clear from the original signatures until one read the description.
timmywil
approved these changes
May 17, 2021
Member
timmywil
left a comment
There was a problem hiding this comment.
LGTM. I reviewed with whitespace off. Side note: I wish I could review this rendered as it seems easier to miss things in diffs.
Member
Author
|
@timmywil I pushed one more commit to remove a redundant sentence. As for how it looks after the changes, this is the top of the page: You can compare that to what we have now. Please have a look. |
Member
|
This looks familiar and may be fixed elsewhere, but there's an issue with the return on |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That signature removes all classes which wasn't that clear from the original
signatures until one read the description.
I recommend reviewing with whitespace changes disabled as the whole file had to be indented.
This has been a point of confusion at my company recently and even I didn't quickly find that it was actually documented as the
removeClass( [ className ] )signature was describing two essentially different signatures.