Skip to content

removeClass: Separate the signature with no parameters #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2021

Conversation

mgol
Copy link
Member

@mgol mgol commented May 13, 2021

That signature removes all classes which wasn't that clear from the original
signatures until one read the description.

I recommend reviewing with whitespace changes disabled as the whole file had to be indented.

This has been a point of confusion at my company recently and even I didn't quickly find that it was actually documented as the removeClass( [ className ] ) signature was describing two essentially different signatures.

That signature removes all classes which wasn't that clear from the original
signatures until one read the description.
@mgol mgol requested review from dmethvin, gibson042 and timmywil May 13, 2021 13:39
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed with whitespace off. Side note: I wish I could review this rendered as it seems easier to miss things in diffs.

@mgol
Copy link
Member Author

mgol commented May 17, 2021

@timmywil I pushed one more commit to remove a redundant sentence.

As for how it looks after the changes, this is the top of the page:
Screen Shot 2021-05-17 at 18 30 40
and this is where the second, new entry starts:
Screen Shot 2021-05-17 at 18 30 58

You can compare that to what we have now. Please have a look.

@timmywil
Copy link
Member

This looks familiar and may be fixed elsewhere, but there's an issue with the return on removeClass(function).
image

@mgol
Copy link
Member Author

mgol commented May 17, 2021

@timmywil Yeah, this is tracked in #1184, there's a PR I need to review.

@mgol mgol merged commit ab8a2d3 into jquery:main May 20, 2021
@mgol mgol deleted the removeClass-all branch May 20, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants