Skip to content

prevAll:uniqueAll: Add uniqueAll, use it in reverse doc order examples #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 19, 2022

Description

.prevAll() returns elements in the reverse document order. This
can pose issues when used with APIs like .append() or .wrapAll().
Document how to deal with the issue with help from jQuery.uniqueSort().

Ref gh-1215
Ref jquery/jquery#5149

This is another version of #1215, meant to be merged after jQuery 3.7.0 gets released.

This PR includes a stub for the 3.7 category and changes the jQuery version used in examples to the 3.x-git one. This needs to be changed to the real 3.7.0 one after that version gets released. Those two issues need to be addressed before this PR is moved out of the draft status. However, other than that, the PR is ready for reviews.

Screenshots

.prevAll()

Screenshots of the .prevAll() page changes from this PR:

  1. A note at the end of the main description (just before examples): Screen Shot 2022-12-19 at 15 41 26
  2. The last example: Screen Shot 2022-12-19 at 15 41 55 Screen Shot 2022-12-19 at 15 42 10

.uniqueSort()

Screenshots of the new .uniqueSort() page (there's also a second example at the end that's a copy of the .prevAll() one:
Screen Shot 2022-12-19 at 16 55 02
Screen Shot 2022-12-19 at 16 55 16

@mgol mgol added this to the 3.7.0 milestone Dec 19, 2022
@mgol mgol requested review from timmywil and gibson042 December 19, 2022 14:53
@mgol mgol self-assigned this Dec 19, 2022
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mgol mgol force-pushed the prevAll-uniqueSort-3.7 branch from 76e86ef to e206678 Compare December 19, 2022 21:21
@mgol mgol changed the title prevAll: Document issues with reverse doc order prevAll: Document issues with reverse doc order - jQuery 3.7 version Dec 19, 2022
@mgol mgol force-pushed the prevAll-uniqueSort-3.7 branch 2 times, most recently from 95ee241 to 05c167b Compare January 15, 2023 21:10
Also, use it in `.prevAll()` examples instead of the
older `jQuery.uniqueSort()`.

In addition, update jQuery used in examples to `3.7.0`
and add the category for jQuery `3.7`.
@mgol mgol force-pushed the prevAll-uniqueSort-3.7 branch from 05c167b to 3abe2c6 Compare May 11, 2023 19:48
@mgol mgol marked this pull request as ready for review May 11, 2023 19:48
@mgol mgol changed the title prevAll: Document issues with reverse doc order - jQuery 3.7 version prevAll:uniqueAll: Add uniqueAll, use it in reverse doc order examples May 11, 2023
@mgol mgol merged commit e52362a into jquery:main May 11, 2023
@mgol mgol deleted the prevAll-uniqueSort-3.7 branch May 11, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants