prevAll:uniqueAll: Add uniqueAll, use it in reverse doc order examples #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76e86ef to
e206678
Compare
mgol
commented
Dec 19, 2022
mgol
commented
Dec 19, 2022
mgol
commented
Dec 19, 2022
95ee241 to
05c167b
Compare
Also, use it in `.prevAll()` examples instead of the older `jQuery.uniqueSort()`. In addition, update jQuery used in examples to `3.7.0` and add the category for jQuery `3.7`.
05c167b to
3abe2c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.prevAll()returns elements in the reverse document order. Thiscan pose issues when used with APIs like
.append()or.wrapAll().Document how to deal with the issue with help from
jQuery.uniqueSort().Ref gh-1215
Ref jquery/jquery#5149
This is another version of #1215, meant to be merged after jQuery 3.7.0 gets released.
This PR includes a stub for the
3.7category and changes the jQuery version used in examples to the3.x-gitone. This needs to be changed to the real3.7.0one after that version gets released. Those two issues need to be addressed before this PR is moved out of the draft status. However, other than that, the PR is ready for reviews.Screenshots
.prevAll()Screenshots of the
.prevAll()page changes from this PR:.uniqueSort()Screenshots of the new
.uniqueSort()page (there's also a second example at the end that's a copy of the.prevAll()one: