Skip to content

Update jQuery.ajax.xml: change option type to method#1218

Closed
dom-rau wants to merge 1 commit into
jquery:mainfrom
dom-rau:umarloczek-patch-1
Closed

Update jQuery.ajax.xml: change option type to method#1218
dom-rau wants to merge 1 commit into
jquery:mainfrom
dom-rau:umarloczek-patch-1

Conversation

@dom-rau
Copy link
Copy Markdown

@dom-rau dom-rau commented Jan 11, 2023

No description provided.

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have one comment.

Comment thread entries/jQuery.ajax.xml
<p>For more information on JSONP, see the <a href="https://bob.pythonmac.org/archives/2005/12/05/remote-json-jsonp/">original post detailing its use</a>.</p>
<h4 id="sending-data-to-server">Sending Data to the Server</h4>
<p>By default, Ajax requests are sent using the GET HTTP method. If the POST method is required, the method can be specified by setting a value for the <code>type</code> option. This option affects how the contents of the <code>data</code> option are sent to the server. POST data will always be transmitted to the server using UTF-8 charset, per the W3C XMLHTTPRequest standard.</p>
<p>By default, Ajax requests are sent using the GET HTTP method. If the POST method is required, the method can be specified by setting a value for the <code>method</code> option. If you're using versions of jQuery prior to 1.9.0 you should use `type` option. This option affects how the contents of the <code>data</code> option are sent to the server. POST data will always be transmitted to the server using UTF-8 charset, per the W3C XMLHTTPRequest standard.</p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not deprecating the type option so this wording is not ideal IMO. Can we just mention both and only indicate that the method one requires 1.9.0 or newer?

@mgol
Copy link
Copy Markdown
Member

mgol commented May 10, 2023

@dominikarauk ping

@dom-rau dom-rau closed this by deleting the head repository Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants