Skip to content

fixes 139 - With/Without example#158

Closed
pobocks wants to merge 1 commit into
jquery:masterfrom
pobocks:issue_139
Closed

fixes 139 - With/Without example#158
pobocks wants to merge 1 commit into
jquery:masterfrom
pobocks:issue_139

Conversation

@pobocks
Copy link
Copy Markdown
Contributor

@pobocks pobocks commented Oct 18, 2012

Improved example for andSelf - clearly shows with and without.

This commit doesn't change documentation wording - possibly might make sense to leave issue open for future improvement, but I think this commit helps.

@kswedberg
Copy link
Copy Markdown
Member

Looks great, Dave! If you could do a couple things before I merge this in, that would be great:

  • Remove trailing white space on line 29
  • Remove the indentation in the example so that the html, css, and js start at column 1 and indent from there.

By the way, not sure what code editor you're using, but both TextMate and Sublime Text 2 have bundles/packages that automatically strip EOL white space on Save. I find that very helpful.

Thanks!

@pobocks
Copy link
Copy Markdown
Contributor Author

pobocks commented Oct 18, 2012

Will do when I get home from work. I have my work Aquamacs set up to kill
trailing whitespace on save - I just forgot to set it up at home.
On Oct 18, 2012 8:38 AM, "Karl Swedberg" notifications@github.com wrote:

Looks great, Dave! If you could do a couple things before I merge this in,
that would be great:

  • Remove trailing white space on line 29
  • Remove the indentation in the example so that the html, css, and js
    start at column 1 and indent from there.

By the way, not sure what code editor you're using, but both TextMate and
Sublime Text 2 have bundles/packages that automatically strip EOL white
space on Save. I find that very helpful.


Reply to this email directly or view it on GitHubhttps://github.com//pull/158#issuecomment-9562726.

@kswedberg
Copy link
Copy Markdown
Member

Awesome! thanks!

@pobocks
Copy link
Copy Markdown
Contributor Author

pobocks commented Oct 18, 2012

Fixed, I believe.

@kswedberg kswedberg closed this Oct 19, 2012
@kswedberg
Copy link
Copy Markdown
Member

Thanks, @pobocks!

I'm not sure why the pull request and issue weren't auto-closed. Maybe we need to put a "#" in front of the issue number. Let's try that next time (if you don't remember, I'll add it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants