Skip to content

Fix incorrect override code for cors headers in firefox #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weikinhuang wants to merge 3 commits into from
Closed

Fix incorrect override code for cors headers in firefox #258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b934176
Fix incorrect override code for cors headers in firefox
weikinhuang Feb 25, 2013
4412dad
code style
weikinhuang Feb 25, 2013
37a402b
iterate through array with $.each
weikinhuang Feb 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions entries/jQuery.ajax.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,29 +284,35 @@ jqxhr.always(function() { alert("second complete"); });</code></pre>
<p><strong>At present</strong>, due to a bug in Firefox where <code>.getAllResponseHeaders()</code> returns the empty string although <code>.getResponseHeader('Content-Type')</code> returns a non-empty string, automatically decoding JSON CORS responses in Firefox with jQuery is not supported.</p>
<p>A workaround to this is possible by overriding <code>jQuery.ajaxSettings.xhr</code> as follows:</p>
<pre><code>
var _super = jQuery.ajaxSettings.xhr;
jQuery.ajaxSettings.xhr = function () {
var xhr = _super(),
getAllResponseHeaders = xhr.getAllResponseHeaders;
(function () {
var _super = jQuery.ajaxSettings.xhr,
xhrCorsHeaders = ["Cache-Control", "Content-Language", "Content-Type", "Expires", "Last-Modified", "Pragma"];
Copy link
Copy Markdown
Member

@mikesherov mikesherov Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ "Cache-Control", "Content-Language", "Content-Type", "Expires", "Last-Modified", "Pragma" ];


xhr.getAllResponseHeaders = function () {
if ( getAllResponseHeaders() ) {
return getAllResponseHeaders();
}
var allHeaders = "";
jQuery.ajaxSettings.xhr = function () {
var xhr = _super(),
getAllResponseHeaders = xhr.getAllResponseHeaders;

$( ["Cache-Control", "Content-Language", "Content-Type",
"Expires", "Last-Modified", "Pragma"] )
.each(function (i, header_name) {
if ( xhr.getResponseHeader( header_name ) ) {
allHeaders += header_name + ": " + xhr.getResponseHeader( header_name ) + "\n";
xhr.getAllResponseHeaders = function () {
var allHeaders = "";
try {
allHeaders = getAllResponseHeaders.apply(xhr);
Copy link
Copy Markdown
Member

@mikesherov mikesherov Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( xhr );

if ( allHeaders ) {
return allHeaders;
}
} catch (e) {
Copy link
Copy Markdown
Member

@mikesherov mikesherov Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( e )

}

$( xhrCorsHeaders ).each(function (i, headerName) {
if ( xhr.getResponseHeader( headerName ) ) {
Copy link
Copy Markdown
Member

@mikesherov mikesherov Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( i, headerName )

allHeaders += headerName + ": " + xhr.getResponseHeader( headerName ) + "\n";
}
});
return allHeaders;
});
};
};

return xhr;
};
return xhr;
};
})();
</code></pre>

<h4 id="extending-ajax">Extending Ajax</h4>
Expand Down