Skip to content

Clarified that closest() returns 0 or 1 element /per original element/. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2012

Conversation

jmm
Copy link
Contributor

@jmm jmm commented May 21, 2012

I don't think the closest() documentation is clear that it will return 0 or 1 element per original element:

Get the first element that matches the selector

The returned jQuery object contains zero or one element

This patch is an attempt to clarify that.

@kswedberg kswedberg merged commit ce171d6 into jquery:master Jun 3, 2012
@kswedberg
Copy link
Member

Thanks so much for the pull request! I'm so sorry that my feeble attempt at merging it in somehow lost your commit authorship. I'm not sure how exactly that happened, but I'll look into it and try not to let it happen again.

@jmm
Copy link
Contributor Author

jmm commented Jun 4, 2012

Thanks Karl, don't worry about it. How does the problem actually show up? I see my commits in the repo and in the github history, and I see your merge commits.

@kswedberg
Copy link
Member

oh, wow, your commits are there, after all! I just hadn't scrolled down far enough. that's what I get for taking so long to merge them in! :)

@jmm
Copy link
Contributor Author

jmm commented Jun 6, 2012

Yeah, that'll teach you to keep my pull requests cooling their heels!

Thanks,
Jesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants