Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented May 21, 2013

@mgol
Copy link
Member Author

mgol commented May 22, 2013

I hope that's all that's needed here, I'm not familiar with syntax so I just wrote what I saw under the selector property. :)

@kswedberg
Copy link
Member

We should probably put a note in longdesc, but I can do that after pulling in your change. Thanks for catching this!

@mgol
Copy link
Member Author

mgol commented May 22, 2013

Right. I'll add a note in a moment unless you're into it now.

@kswedberg
Copy link
Member

If you're up for doing it, go for it. thanks! 👍

@mgol
Copy link
Member Author

mgol commented May 22, 2013

We also need a slug for deprecated-1.10.

@mgol
Copy link
Member Author

mgol commented May 22, 2013

I introduced changes you mentioned, added a version/1.3 slug in selector.xml and added a deprecated/deprecated-1.10 slug. I'm not sure what to do about the URL to the blog post since it's not there yet. ;)

@kswedberg
Copy link
Member

ooooh! If it's not deprecated until 1.10, then we should hold off on merging it in. As soon as it's released, add the URL, and I'll merge the PR and publish. cool?

@mgol
Copy link
Member Author

mgol commented May 22, 2013

Sure! We have a race condition here. ;)

@mgol
Copy link
Member Author

mgol commented May 22, 2013

Is everything else OK? I'd like for this URL to be the only thing needed to fix.

@mgol
Copy link
Member Author

mgol commented May 24, 2013

jQuery 1.10 and 2.0.1 just went out so I updated the link and rebased to master. Can you pull it? :)

@kswedberg kswedberg closed this in a026565 May 25, 2013
@kswedberg
Copy link
Member

Thank you!

@mgol
Copy link
Member Author

mgol commented May 27, 2013

This needs to be published to http://api.jquery.com/context/ as well.

@mgol mgol deleted the deprecate_context branch May 27, 2013 16:51
@kswedberg
Copy link
Member

Yes, thanks. 👍 It's published now.

@mgol
Copy link
Member Author

mgol commented May 28, 2013

Thanks!

By the way, IMHO those initial paragraphs about deprecation could use some more style accent to catch people's eyes, now if you quickly scan the page you may easily not notice this information.

@sunsean
Copy link

sunsean commented Jul 13, 2013

Is there a recommendation for saving the query or "find/filter" steps the user took to get to the current .context and .selector? Or is that simply considered unreliable now? is there a better forum for this discussion?

@dmethvin
Copy link
Member

The forum is a better place to ask questions. In general, any use of .context indicates bad assumptions or a bad plugin API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants