-
Notifications
You must be signed in to change notification settings - Fork 261
Deprecate context property #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I hope that's all that's needed here, I'm not familiar with syntax so I just wrote what I saw under the |
|
We should probably put a note in longdesc, but I can do that after pulling in your change. Thanks for catching this! |
|
Right. I'll add a note in a moment unless you're into it now. |
|
If you're up for doing it, go for it. thanks! 👍 |
|
We also need a slug for deprecated-1.10. |
|
I introduced changes you mentioned, added a |
|
ooooh! If it's not deprecated until 1.10, then we should hold off on merging it in. As soon as it's released, add the URL, and I'll merge the PR and publish. cool? |
|
Sure! We have a race condition here. ;) |
|
Is everything else OK? I'd like for this URL to be the only thing needed to fix. |
|
jQuery 1.10 and 2.0.1 just went out so I updated the link and rebased to |
|
Thank you! |
|
This needs to be published to http://api.jquery.com/context/ as well. |
|
Yes, thanks. 👍 It's published now. |
|
Thanks! By the way, IMHO those initial paragraphs about deprecation could use some more style accent to catch people's eyes, now if you quickly scan the page you may easily not notice this information. |
|
Is there a recommendation for saving the query or "find/filter" steps the user took to get to the current |
|
The forum is a better place to ask questions. In general, any use of |
Fixes: http://bugs.jquery.com/ticket/13801