Skip to content

Fix XSL Types path in builder #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

shaneriley
Copy link
Contributor

Fixes issues #320, #309 and all other links throughout the documentation that links to a type on the /Types page.

@shaneriley
Copy link
Contributor Author

Is this ever getting looked at? It's incredibly annoying to click a link that refers to a section of the Types page and have it just dump you at the top.

@kswedberg
Copy link
Member

sorry. I'll try to merge this in tonight.

@kswedberg
Copy link
Member

Hi @shaneriley, I merged this in at fee98c7. However, when I looked at the diff, the only change I saw was the addition of a "/" for one href on the Types page. It doesn't seem to do all that you claim it does. Could you possibly have put together a different commit / pull request in the https://github.com/jquery/grunt-jquery-content repo? That's where the XSL is.

@kswedberg kswedberg closed this Jul 31, 2013
@shaneriley
Copy link
Contributor Author

I think the change I made to the page builder didn't make it into the commit. All paths created with the page builder to a specific type heading were created without the / separator between page path and local name. I'll check it out later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants