append() clones for all elements but the last one, not first #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be tracked to this line in the code: https://github.com/jquery/jquery/blob/master/src/manipulation.js#L42 And for `domManip`: https://github.com/jquery/jquery/blob/master/src/manipulation.js#L233 `iNoClone` is what decides if the element is cloned or not, and this is set a bit above to `length - 1` which means it won't clone for the last one. Can also be seen in this "pen": http://codepen.io/adrolldev/pen/zmonw
|
Hi Timothee, sorry for the delay in responding to this pull request. We'd like everyone who contributes to any of jQuery's repos to sign a Contributor License Agreement (CLA). Would you mind doing that at http://contribute.jquery.org/CLA/? Please make sure that the name and email address match those in your git config. Thanks! |
|
Hey Karl, no problem. I just filled out the form right now. It feels kind of silly for changing three words, but I understand why you need that. Plus, I'm set up for hopefully future contributions! :) Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be tracked to this line in the code:
https://github.com/jquery/jquery/blob/master/src/manipulation.js#L42
And for
domManip:https://github.com/jquery/jquery/blob/master/src/manipulation.js#L233
iNoCloneis what decides if the element is cloned or not, and this is set a bit above tolength - 1which means it won't clone for the last one.Can also be seen in this "pen": http://codepen.io/adrolldev/pen/zmonw