fix invalid :eq index (introduced in a3565d9)

[chocolateboy]

No description provided.

[mgol]

This is incorrect; :eq(1) does select the second element; for selecting the first use :eq(0).

[dmethvin]

The correction looks like it is needed to me. the current version says:

$( ".myclass:eq(2)" ) selects the second element in the document with the class myclass

[kswedberg]

So the pull request is invalid, but that paragraph needs to be updated. Since it says, "selects the second element in the document with the class myclass, rather than the first," I'm guessing at some point that selector was changed from :eq(1) to :eq(2). Anyway, fixed in f2dc385

[chocolateboy]

I'm guessing at some point that selector was changed from :eq(1) to :eq(2)

There's no need to guess: "introduced in a3565d9".

the pull request is invalid

No it isn't, and the "fix" you've committed is less clear than the old (pre-a3565d9) example (why on earth would one illustrate a 0-based index with :eq(2)?), but whatever...

[scottgonzalez]

I agree. The PR should've landed instead of changing the sentence.

[dmethvin]

Either way corrects the problem, but I agree it would be preferable to have landed the original PR since it pointed out the issue. @chocolateboy have you signed the CLA? If you're planning to make other contributions it would help to do that since we can't land anything until you do.

[chocolateboy]

@chocolateboy have you signed the CLA?

I'll sign it if necessary, but I was hoping I could avoid it for a 1-character patch :-) I've never spotted any issues with the jQuery documentation apart from this, so I can't see myself becoming a regular contributor.

[kswedberg]

Sorry. I misread the pull request.Of course it's valid. My bad.

[kswedberg]

In fact, it was originally written correctly as :eq(1) until a code cleanup commit this summer changed it. probably a typo.

[kswedberg]

@chocolateboy: I know it might seem silly to sign a CLA for one character, but we really want to do the right thing for all concerned. As it states, "This license protects You, the jQuery Foundation and licensees; it does not change your rights to use your own Contributions for any other purpose." It should take less than a minute to read it and digitally sign at http://contribute.jquery.org/CLA/ Once you've done that, I'll merge your pull request ASAP.

Thanks so much, and sorry again for the misunderstanding.

[mgol]

@chocolateboy Sorry, I've mixed the lines in the diff, you were obviously correct!

[chocolateboy]

@kswedberg: OK, I've signed it.

[kswedberg]

@chocolateboy: thank you! Commit merged at 916f055 and deployed.

[scottgonzalez]

@chocolateboy Can you please sign the CLA again, this time with your real name?