Note new sane 1.9+ behavior for disconnected elems, ref gh-240#436
Closed
dmethvin wants to merge 1 commit into
Closed
Note new sane 1.9+ behavior for disconnected elems, ref gh-240#436dmethvin wants to merge 1 commit into
dmethvin wants to merge 1 commit into
Conversation
Member
|
Closed by 501491b |
Member
|
@dmethvin Could you delete the branch created for this PR? No reason for it to exist anymore :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since behavior of older versions was flakey with disconnected elements I decided to just remove the reference rather than explain it, since people should avoid the practice with these APIs anyway