Skip to content

Amended text API documentation #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Amended text API documentation #460

wants to merge 3 commits into from

Conversation

johnnyreilly
Copy link
Contributor

To allow number / boolean to be passed based on input from @dmethvin here.

To allow number / boolean to be passed based on input from @dmethvin
@kswedberg
Copy link
Member

Thanks for this, @johnnyreilly. If we note that the argument can be Number or Boolean, I think we should also mention that they'll be converted to string representations. What do you think?

@johnnyreilly
Copy link
Contributor Author

That sounds entirely sensible/useful! Shall I amend the comment in PR to reflect this?

@kswedberg
Copy link
Member

Yes, please, and thank you.

@johnnyreilly
Copy link
Contributor Author

Hope this comment looks okay @kswedberg - let me know if it needs tweaking.

@johnnyreilly
Copy link
Contributor Author

No problem - see latest commit (I uppercased the "S" on "string" to fall in line with Number and Boolean BTW)

@kswedberg
Copy link
Member

Beautiful! Thanks, @johnnyreilly. One last thing: we'd like everyone who contributes to any of jQuery's repos to sign a Contributor License Agreement (CLA). Would you mind doing that at http://contribute.jquery.org/CLA/? Let me know when that's done, and I'll push your changes posthaste.

@johnnyreilly
Copy link
Contributor Author

Done!

@kswedberg kswedberg closed this in 58be0dd Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants