Skip to content

fix second argument of deferred.notifyWith() #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix second argument of deferred.notifyWith() #461

wants to merge 1 commit into from

Conversation

bttmly
Copy link
Contributor

@bttmly bttmly commented Mar 13, 2014

This method takes an array as it’s second argument, just like deferred.resolveWith() and .deferred.rejectWith(). Currently it reads

Type: Object
Optional arguments that are passed to the progressCallbacks.

It should read:

Type: Array
An optional array of arguments that are passed to the progressCallbacks.

This method takes an array as it’s second argument, just like
deferred.resolveWith() and .deferred.rejectWith()
@kswedberg
Copy link
Member

Hi @nickb1080. It doesn't look like you've signed the CLA. Could you please do that so we can get your pull request merged in (http://contribute.jquery.org/CLA/)?
Thanks!

@bttmly
Copy link
Contributor Author

bttmly commented Jul 5, 2014

Hey Karl,

Just signed the CLA. Thanks for the heads up!

Best regards,
Nick

On Saturday, July 5, 2014, Karl Swedberg notifications@github.com wrote:

Hi @nickb1080 https://github.com/nickb1080. It doesn't look like you've
signed the CLA. Could you please do that so we can get your pull request
merged in (http://contribute.jquery.org/CLA/)?
Thanks!


Reply to this email directly or view it on GitHub
#461 (comment).

@kswedberg kswedberg closed this in bffd21e Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants