Skip to content

.inArray method compares values strictly, adding a line about it #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

baamenabar
Copy link
Contributor

The comparison of values within the jQuery.inArray method is made strictly. Added a line stating so with a small example.

@kswedberg
Copy link
Member

Hi @baamenabar : We'd like everyone who contributes to any of jQuery's repos to sign a Contributor License Agreement (CLA). Would you mind doing that at http://contribute.jquery.org/CLA/? Let me know when you've signed it, so we can get your pull request merged in.

@baamenabar
Copy link
Contributor Author

Helló, no problem, just signed the CLA with the same public email from my github account.

@kswedberg
Copy link
Member

Thanks, @baamenabar. Actually, the email you sign the CLA with should be the same as the one in your git config ( ...@fliin.com? ).

@baamenabar
Copy link
Contributor Author

oh! that one!
just updated my git config to baamenabar@gmail.com
...@fliin.com it's for signing up to new untrusted services.

Agustín Amenabar
Médula Diseño
+562 918 0224

On Tue, Jul 8, 2014 at 3:59 PM, Karl Swedberg notifications@github.com
wrote:

Thanks, @baamenabar https://github.com/baamenabar. Actually, the email
you sign the CLA with should be the same as the one in your git config (
...@fliin.com? ).


Reply to this email directly or view it on GitHub
#470 (comment).

@kswedberg
Copy link
Member

Hi @baamenabar, I'm about to merge in your pull request. I hope you don't mind I modified it a bit. I did make sure that it kept your authorship intact, though, so you get credit. 😄

@baamenabar
Copy link
Contributor Author

Great! thanks, reads much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants