Skip to content

Remove reference to responseHTML#483

Closed
johnnyreilly wants to merge 2 commits into
jquery:masterfrom
johnnyreilly:master
Closed

Remove reference to responseHTML#483
johnnyreilly wants to merge 2 commits into
jquery:masterfrom
johnnyreilly:master

Conversation

@johnnyreilly
Copy link
Copy Markdown
Contributor

As part of the work on the TypeScript jQuery typings we believe we found an erroneous reference to responseHTML in the API docs. This PR removes reference to responseHTML in favour of responseXML. You can read details of the rationale here:

DefinitelyTyped/DefinitelyTyped#1471 (comment)

@kswedberg
Copy link
Copy Markdown
Member

Thanks for catching this, @johnnyreilly. I don't think xhr.responseXML would work in the example, though. I just tested by requesting an HTML document, and xhr.responseXML was undefined. Seems that changing "responseHTML" to "responseText" is more accurate.

@johnnyreilly
Copy link
Copy Markdown
Contributor Author

No problem @kswedberg - have made the change. My bad for not double checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants