Skip to content

Remove reference to responseHTML #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove reference to responseHTML #483

wants to merge 2 commits into from

Conversation

johnnyreilly
Copy link
Contributor

As part of the work on the TypeScript jQuery typings we believe we found an erroneous reference to responseHTML in the API docs. This PR removes reference to responseHTML in favour of responseXML. You can read details of the rationale here:

DefinitelyTyped/DefinitelyTyped#1471 (comment)

@kswedberg
Copy link
Member

Thanks for catching this, @johnnyreilly. I don't think xhr.responseXML would work in the example, though. I just tested by requesting an HTML document, and xhr.responseXML was undefined. Seems that changing "responseHTML" to "responseText" is more accurate.

@johnnyreilly
Copy link
Contributor Author

No problem @kswedberg - have made the change. My bad for not double checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants