-
Notifications
You must be signed in to change notification settings - Fork 264
Added a standards divergence warning to binders #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
For consistency.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default. Additionally, clarify somewhere else that return false does more than just .preventDefault().
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
I will add the note to the rest if this pull request is approved. |
@phistuck : thanks for the pull request. I think this is a fine thing to add, but it would probably be better to put the note in notes.xsl and just include it in the entries. Look at /entries/after.xml for an example of where and how to include the note ( e.g. @scottgonzalez : I'm actually not sure which is the appropriate approach here: adding a when condition to notes.xsl or adding a file in the /includes/ directory. Thoughts? |
Also, @phistuck, could you please sign the CLA at http://contribute.jquery.org/CLA/? Thanks! |
@kswedberg I have already. |
Ah, I see now. thanks. |
I'd use |
thanks for weighing in, @scottgonzalez. @phistuck, if you wouldn't mind updating the pull request as suggested, that would be great. |
@kswedberg - sure, I hope to get to it this weekend. |
@phistuck - ping - still interested in this? |
Generally, yes, but I am not sure when I will get to it. Sorry. |
@phistuck Bump about the CLA. You will also need to include your real name in your git config. |
It really seems strange to repeat this on so many different pages (this isn't even the complete list) and will be hard to maintain. Also the results are different for |
@scottgonzalez @arthurvr @phistuck The problem is the CLA is signed with a different email then these commits use. |
We can use |
I agree that |
I will probably not get to it. Anyone of you is free to take this. Closing this. |
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
This adds a bold note to some bind methods (part I).