Skip to content

Added a standards divergence warning to binders #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

phistuck
Copy link
Contributor

Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
This adds a bold note to some bind methods (part I).

phistuck added 10 commits June 14, 2014 16:39
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.

Additionally, clarify somewhere else that return false does more than just .preventDefault().
Returning false in jQuery event handlers stops the propagation of the event, while returning false in native event listeners only prevents the default.
@phistuck
Copy link
Contributor Author

I will add the note to the rest if this pull request is approved.

@kswedberg
Copy link
Member

@phistuck : thanks for the pull request. I think this is a fine thing to add, but it would probably be better to put the note in notes.xsl and just include it in the entries. Look at /entries/after.xml for an example of where and how to include the note ( e.g. <note id="disconnected-manipulation" type="additional" data-title=".after()"/> ).

@scottgonzalez : I'm actually not sure which is the appropriate approach here: adding a when condition to notes.xsl or adding a file in the /includes/ directory. Thoughts?

@kswedberg
Copy link
Member

Also, @phistuck, could you please sign the CLA at http://contribute.jquery.org/CLA/? Thanks!

@phistuck
Copy link
Contributor Author

phistuck commented Jul 6, 2014

@kswedberg I have already.

@kswedberg
Copy link
Member

Ah, I see now. thanks.

@scottgonzalez
Copy link
Member

I'd use notes.xsl.

@kswedberg
Copy link
Member

thanks for weighing in, @scottgonzalez.

@phistuck, if you wouldn't mind updating the pull request as suggested, that would be great.

@phistuck
Copy link
Contributor Author

phistuck commented Jul 7, 2014

@kswedberg - sure, I hope to get to it this weekend.

@gnarf
Copy link
Member

gnarf commented Dec 22, 2014

@phistuck - ping - still interested in this?

@phistuck
Copy link
Contributor Author

Generally, yes, but I am not sure when I will get to it. Sorry.

@arthurvr
Copy link
Member

@phistuck Bump about the CLA. You will also need to include your real name in your git config.

@scottgonzalez
Copy link
Member

@arthurvr @phistuck has requested to remain anonymous. You should see the approval for that in the CLA sheet.

@dmethvin
Copy link
Member

It really seems strange to repeat this on so many different pages (this isn't even the complete list) and will be hard to maintain. Also the results are different for onevent-style handlers as well, it's not mentioned here. There should be a much DRY-er way to do this, perhaps an event overview page with all the differences.

@arschmitz
Copy link
Member

@scottgonzalez @arthurvr @phistuck The problem is the CLA is signed with a different email then these commits use.

@gnarf
Copy link
Member

gnarf commented Dec 23, 2014

We can use notes.xsl @dmethvin - there is a DRYer way

@dmethvin
Copy link
Member

I agree that notes.xsl avoids copy/pasta of the actual phrase, but it duplicates the information about events across a huge swath of pages which seems bad. There's quite a bit of general discussion regarding events in the entry for .on() that applies to all events and I wouldn't want to duplicate that across pages either.

@phistuck
Copy link
Contributor Author

I will probably not get to it. Anyone of you is free to take this. Closing this.

@phistuck phistuck closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants