Update visible-selector.xml#522
Closed
AurelioDeRosa wants to merge 1 commit into
Closed
Conversation
Fixes issue jquery#409.
Member
There was a problem hiding this comment.
@AurelioDeRosa . This is good information to have in here. Thanks! I'm just not sure about the phrasing (e.g. "is completely useless" and "It'll be always"). Mind if I merge it in with some editing? Authorship will still go to you, of course.
Member
Author
There was a problem hiding this comment.
@kswedberg. Hi! Feel free to change anything you want to further improve the documentation. I also don't mind about the authorship as long as we, together, can improve the project. :)
Member
Author
|
@kswedberg Is this PR good to merge? |
Member
|
Thanks for the ping, @AurelioDeRosa . I'll check it out tonight. |
Member
Author
|
Thank you for merging @kswedberg. I think there are other PRs ready to be merged, but I don't want to bother you pinging on each of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #409.