-
Notifications
You must be signed in to change notification settings - Fork 264
Update attr.xml #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update attr.xml #533
Conversation
Removed incorrect sentence (possibly something that was valid in older versions of jQuery?) as proved here: http://jsfiddle.net/73cKp/1/
On a side note, I'm not sure of the correctness of this quote:
I ran the same code on Internet Explorer 6-7, although using the F12 Developer Tools, and the attribute was changed. |
A fresh |
Thank you for the heads up @dmethvin. I've been able to reproduce the issue with your hint, so the second note is valid. Any thought about the PR? |
Yeah, this does need rewriting since we took off the prohibition in jQuery 1.9. How about this?
|
LGTM. I also want to highlight that a similar note is present when discussing the method as a getter, which seems out of place to me. Should we remove the note in the getter section and update my PR to use your text? |
Yeah, the getter note doesn't belong there I think. |
Hi @dmethvin. I've updated the PR based on our discussion. |
Any news on this PR? |
Hey @AurelioDeRosa - going through some old pulls this week and ran into this one:
I don't see an update, this pull still shows removing the line entirely. Would you double check that you did actually update it? I'd be happy to merge this in! |
Hi @gnarf. I've updated the PR based on the discussion. I don't why it wasn't already changed, but I guess I posted the message in the wrong thread. |
Thanks, @AurelioDeRosa! Does this PR look good now, @gnarf @dmethvin? |
@arthurvr No objections in a month, I think you can merge this PR. |
Removed incorrect sentence (possibly something that was valid in older versions of jQuery?) as proved here: http://jsfiddle.net/73cKp/1/