Skip to content

jQuery.getScript: Fix external link to jquery-color#584

Closed
gnarf wants to merge 1 commit into
masterfrom
583-fix-getScript
Closed

jQuery.getScript: Fix external link to jquery-color#584
gnarf wants to merge 1 commit into
masterfrom
583-fix-getScript

Conversation

@gnarf
Copy link
Copy Markdown
Member

@gnarf gnarf commented Nov 5, 2014

GitHub's rawusercontent url's don't serve proper mime types, so we can use
the version of jQuery color found on code.jquery.com

Fixes #583

GitHub's rawusercontent url's don't serve proper mime types, so we can use
the version of jQuery color found on code.jquery.com

Fixes #583
@mgol
Copy link
Copy Markdown
Member

mgol commented Nov 6, 2014

We should use proper releases and not -git IMO. But this PR is still better than what we have currently, especially that it points to master anyway. So 👍 from me but we should switch the URL later.

@gnarf
Copy link
Copy Markdown
Member Author

gnarf commented Nov 6, 2014

I'll switch to latest stable and land it. I also agree and I think this was
my example anyway! Good point.
On Nov 6, 2014 5:55 AM, "Michał Gołębiowski" notifications@github.com
wrote:

We should use proper releases and not -git IMO. But this PR is still
better than what we have currently, especially that it points to master
anyway. So [image: 👍] from me but we should switch the URL later.


Reply to this email directly or view it on GitHub
#584 (comment).

@kswedberg
Copy link
Copy Markdown
Member

Thanks for the fix, @gnarf. Merging it in soon.

@kswedberg
Copy link
Copy Markdown
Member

Closed by f9531d8

@kswedberg kswedberg closed this Nov 6, 2014
@mgol mgol deleted the 583-fix-getScript branch November 6, 2014 13:26
@kswedberg
Copy link
Copy Markdown
Member

Sorry, @gnarf and @mzgol. Seems I landed this before you had a chance to change it to latest stable. @gnarf, want me to fix that, or do you want to take care of it?

@gnarf
Copy link
Copy Markdown
Member Author

gnarf commented Nov 6, 2014

If you could, that would rock! Thanks Karl!
On Nov 6, 2014 9:06 AM, "Karl Swedberg" notifications@github.com wrote:

Sorry, @gnarf https://github.com/gnarf and @mzgol
https://github.com/mzgol. Seems I landed this before you had a chance
to change it to latest stable. @gnarf https://github.com/gnarf, want me
to fix that, or do you want to take care of it?


Reply to this email directly or view it on GitHub
#584 (comment).

@kswedberg
Copy link
Copy Markdown
Member

you betcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

getScript demo broken

3 participants