Fixed broken example in .index() #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,7 @@ alert('Index: ' + listItem.index('li')); | |||
| <span class="output">Index: 1</span> | |||
| </p> | |||
| <p>If we omit the argument, <code>.index()</code> will return the position of the first element within the set of matched elements in relation to its siblings:</p> | |||
| <pre><code>alert('Index: ' + $('#bar').index();</code></pre> | |||
| <pre><code>alert('Index: ' + $('#bar').index());</code></pre> | |||
There was a problem hiding this comment.
Should we be using alert() at all in the documentation examples?
|
Probably not but a quick grep reveals 39 uses of console.log and 193 uses of alert :) |
|
Unfortunately, |
|
This is true. I'll leave this with you guys. Thanks. |
kswedberg
added a commit
that referenced
this pull request
Oct 14, 2012
Fix broken example in .index(). Thanks @easternbloc. We can revisit the merits of using something other than alert() another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple fix. One of the examples was missing a closing parentheses.