change: note that JS-initiated change does not trigger change event #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,9 @@ $( "#other" ).click(function() { | |||
| </code></pre> | |||
| <p>After this code executes, clicks on <samp>Trigger the handler</samp> will also alert the message. The message will display twice, because the handler has been bound to the <code>change</code> event on both of the form elements.</p> | |||
| <p>As of jQuery 1.4, the <code>change</code> event bubbles in Internet Explorer, behaving consistently with the event in other modern browsers.</p> | |||
| <div class="warning"> | |||
| <p><strong>Note: </strong> dynamically changing the value of an input element, using <a href="/val"><code>.val()</code></a> for example, won't fire the event.</p> | |||
There was a problem hiding this comment.
The word "dynamically" is a little bit ambiguous here, since someone might interpret a user-generated change to be dynamic. Perhaps "Changing the value property of an input element using JavaScript..." instead?
There was a problem hiding this comment.
Agreed. I'il update my PR this evening.
7028bd0 to
6dedb28
Compare
6dedb28 to
3b3fbe2
Compare
3b3fbe2 to
833dad6
Compare
|
@dmethvin Does this LGTY now? I did the updates you asked for. |
|
I think the "changing" should be "Changing", otherwise good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #345.