Skip to content

ajax: documented new post and get config object interfaces #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

ajax: documented new post and get config object interfaces #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc2238f
ajax: documented new post and get config objecct interfaces from PR 1999
togakangaroo Jan 9, 2015
f9ce9f0
Update jQuery.get.xml
togakangaroo Jan 12, 2015
d460f74
pr review fixup
togakangaroo Jan 12, 2015
712d28f
set correct version on new $.get method
togakangaroo Jan 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions entries/jQuery.get.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
<entry type="method" name="jQuery.get" return="jqXHR">
<title>jQuery.get()</title>
<signature>
<added>3.0</added>
<argument name="settings" type="PlainObject" optional="false">
<desc>A set of key/value pairs that configure the Ajax request. All properties except for <code>url</code> are optional. A default can be set for any option with <a href="/jQuery.ajaxSetup/">$.ajaxSetup()</a>. See <a href="/jquery.ajax/#jQuery-ajax-settings">jQuery.ajax( settings )</a> for a complete list of all settings. The type option will automatically be set to <code>POST</code>.</desc>
</argument>
</signature>
<signature>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks the indentation. Could you fix that? I'd love to land this PR soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arthur, you could edit this with an --amend IMO, it's a pretty trivial thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Landing right now.

<added>1.0</added>
<argument name="url" type="String">
<desc>A string containing the URL to which the request is sent.</desc>
Expand Down
6 changes: 6 additions & 0 deletions entries/jQuery.post.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<?xml version="1.0"?>
<entry type="method" name="jQuery.post" return="jqXHR">
<title>jQuery.post()</title>
<signature>
<added>3.0</added>
<argument name="settings" type="PlainObject" optional="false">
<desc>A set of key/value pairs that configure the Ajax request. All properties except for <code>url</code> are optional. A default can be set for any option with <a href="/jQuery.ajaxSetup/">$.ajaxSetup()</a>. See <a href="/jquery.ajax/#jQuery-ajax-settings">jQuery.ajax( settings )</a> for a complete list of all settings. Type will automatically be set to <code>POST</code>.</desc>
</argument>
</signature>
<signature>
<added>1.0</added>
<argument name="url" type="String">
Expand Down