Skip to content

Update off.xml #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update off.xml #634

wants to merge 1 commit into from

Conversation

AurelioDeRosa
Copy link
Member

Fix issue #384.

@arthurvr
Copy link
Member

This PR adds a <signature>, but I'd like to see a little more. A more in-depth explanation, an example maybe?

@AurelioDeRosa
Copy link
Member Author

@arthurvr I didn't include an example because the page of the one() method has one that uses this signature and I didn't want to replicate it.

</argument>
</signature>
<signature>
<added>1.7</added>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signature was around earlier than 1.7, I had to keep it working when I refactored the code in 1.7. I'll look for the right version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but not in .off() 😄 Carry on.

@arthurvr
Copy link
Member

LGTM. Shall I merge?

@kswedberg
Copy link
Member

@arthurvr 👍

@arthurvr arthurvr closed this in baef215 Jan 25, 2015
@AurelioDeRosa AurelioDeRosa deleted the patch-5 branch January 25, 2015 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants