jQuery.extend: simplify way of logging objects #661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnarf Would you mind giving this a review? :) |
|
I'd be 👍 to take this into master, perhaps with a |
|
@gnarf Doing it with a comment seems fine to me. Than we can remove that comment once v3 releases, right? |
8624346 to
8c84952
Compare
|
@gnarf Updated PR. Does this version LGTY for master? |
|
Works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had a little silly polyfill for
JSON.stringifyin the examples in thejQuery.extendentry. This overcomplicated the example so should be replaced by something simpler. We can perfectly useJSON.stringifydirectly once v3 released so opening this against thev3.0.0-docsbranch.Would fix gh-658.