Skip to content

Wrap: Clarify that passing a collection uses the first element#700

Closed
arthurvr wants to merge 1 commit into
jquery:masterfrom
arthurvr:wrapJQ
Closed

Wrap: Clarify that passing a collection uses the first element#700
arthurvr wants to merge 1 commit into
jquery:masterfrom
arthurvr:wrapJQ

Conversation

@arthurvr
Copy link
Copy Markdown
Member

@arthurvr arthurvr commented Apr 6, 2015

Fixes gh-698.

@dmethvin
Copy link
Copy Markdown
Member

dmethvin commented Apr 6, 2015

LGTM thanks!

Comment thread entries/wrap.xml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens also when you provide a selector matching more than one element @arthurvr.

@arthurvr arthurvr closed this in a5faca0 Apr 6, 2015
@AurelioDeRosa
Copy link
Copy Markdown
Member

Have you read my comment @arthurvr?

@arthurvr
Copy link
Copy Markdown
Member Author

arthurvr commented Apr 6, 2015

Have you read my comment @arthurvr?

Yes, but I read it too late.

@arthurvr
Copy link
Copy Markdown
Member Author

arthurvr commented Apr 6, 2015

Will do a PR with a fix up.

@arthurvr arthurvr deleted the wrapJQ branch April 6, 2015 13:39
arthurvr added a commit to arthurvr/api.jquery.com that referenced this pull request Apr 6, 2015
arthurvr added a commit that referenced this pull request Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

wrap() uses the first element when provided a jQuery object

4 participants