Skip to content

Conversation

@arthurvr
Copy link
Member

@arthurvr arthurvr commented Apr 6, 2015

Fixes gh-696

@arthurvr
Copy link
Member Author

arthurvr commented Apr 9, 2015

@AurelioDeRosa @dmethvin WDYT?

@AurelioDeRosa
Copy link
Member

I think this PR is fine but it should be changed for context as well.

@arthurvr
Copy link
Member Author

arthurvr commented Apr 9, 2015

Sure thing. Updated that.

@AurelioDeRosa
Copy link
Member

Thank you for the change @arthurvr. This PR is now good to be merged.

arthurvr added a commit that referenced this pull request Apr 13, 2015
arthurvr added a commit that referenced this pull request Apr 13, 2015
@arthurvr
Copy link
Member Author

Merged in v3 branch.

@arthurvr arthurvr closed this Apr 13, 2015
@dmethvin dmethvin added this to the 3.0.0 milestone May 1, 2015
AurelioDeRosa pushed a commit that referenced this pull request May 23, 2016
AurelioDeRosa pushed a commit that referenced this pull request May 23, 2016
timmywil pushed a commit that referenced this pull request Jun 9, 2016
timmywil pushed a commit that referenced this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants