Skip to content

innerWidth: return type unified #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ericaro
Copy link
Contributor

@ericaro ericaro commented Apr 6, 2015

all (width,height, outerWidth, outerHeight, innHeight) dimensions have a return type "Number" but innerWidth which has a return type "Integer".

I don't see the reason for that, so I guess this is a small mistake.

Eric,

all dimensions have a return type "Number" but innerWidth.
@dmethvin
Copy link
Member

dmethvin commented Apr 8, 2015

👍 , although it's not actually a mistake because the method originally could only return an integer. At this point there are cases where it may not be integer so we should clarify it.

@arthurvr
Copy link
Member

arthurvr commented Apr 9, 2015

At this point there are cases where it may not be integer so we should clarify it.

We should probably add a note about that, not just change it?

@dmethvin
Copy link
Member

dmethvin commented Apr 9, 2015

It's not our change that made it more likely to return non-integer values, it's that screens are getting higher resolution and the browser is returning "fractional pixels" more often, for example.

@arthurvr arthurvr closed this in a10fe84 Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants